[15.0][IMP] fieldservice_portal: Display location address, scheduled date and date end#1361
Conversation
|
Hi @renda-dev, @aleuffre, |
ppyczko
changed the title
ppyczko
force-pushed
the
15.0-imp-fieldservice_portal-scheduled-dates
branch
from
2482f34 to
34c0852
Compare
HekkiMelody
left a comment
HekkiMelody
left a comment
There was a problem hiding this comment.
Hello, thank you for the PR!
Pull Requests should not modify .po files directly, as per OCA guidelines
ppyczko
force-pushed
the
15.0-imp-fieldservice_portal-scheduled-dates
branch
2 times, most recently
from
1797bac to
8b0e074
Compare
Hi @aleuffre, thank you for your review. I have reverted the changes to the |
peluko00
left a comment
peluko00
left a comment
There was a problem hiding this comment.
LGTM, tested in runboat and code review
SirPyTech
left a comment
SirPyTech
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I reviewed the code and tried it locally, works great!
See the suggestions and cleanup notes below, nothing blocking though.
|
Can you review comments please @ppyczko ? |
…e, show date start and date end only when filled
ppyczko
force-pushed
the
15.0-imp-fieldservice_portal-scheduled-dates
branch
from
8b0e074 to
b20374b
Compare
|
Thanks for the suggestions @SirPyTech Could you please review to check if it's ready to be merged? @ivantodorovich Thank you in advance |
ppyczko
changed the title
ivantodorovich
left a comment
ivantodorovich
left a comment
There was a problem hiding this comment.
/ocabot merge nobump
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 6640a1d. Thanks a lot for contributing to OCA. ❤️ |
9 participants
This update enhances the portal view for FSM orders by adding the location's address and the scheduled date. Additionally, the "Arrival On Site" (date_start) and "Completion Date" (date_end) fields will now only be displayed when they are filled in, helping to reduce clutter and improve the user experience.
cc https://github.com/APSL 6228
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review